-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit windowing support snapshoted events #195
Conversation
2d185c5
to
7d4bdd4
Compare
...ain/scala/org/apache/pekko/persistence/jdbc/journal/dao/BaseJournalDaoWithReadMessages.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
val atomicWrites = | ||
(start to end).map { j => | ||
AtomicWrite(immutable.Seq(PersistentRepr(payload, j, persistenceId))) | ||
AtomicWrite(immutable.Seq(PersistentRepr(payload, j, persistenceId, writerUuid = writerUuid))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oracle not allow insert null writedUuid
Merged to verify #198 |
Motivation
it also fixed the test failed after #180 merged.
Explan
In the normal case...(the sequence version always start from 1)
After the snapshot, the existing sequence version may start from 1000 or higher.(or something happened unexpectedly, like the migrator test)(the persistenceActor It will not be affected, because the Reply will query HigherSequenceNumber in advance, but queries such as
currentEventsByPersistenceId
can not be required)In this case we should use full windows for the first query only.